Fix mastercard regex anchoring#2799
Open
SarthakDudhe wants to merge 5 commits into
Open
Conversation
…trailing zeros on 1
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2799 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2587 2587
Branches 656 656
=========================================
Hits 2587 2587 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for Issue #2717 is complete and verified!
Grouped and anchored the Mastercard regex correctly in
isCreditCard.js
to avoid unanchored matches on partial strings.
Corrected the digit length validation for the Mastercard 51-55 BIN range from 4 digits (which allowed short Luhn-valid numbers like "5108") to exactly 16 digits.
Added invalid test cases (like "5108", unanchored strings, and incorrect lengths) to
validators.test.js
and verified that all 318 tests pass successfully.